Note:

This PR doesn't impact:

• labels regex
• validator regex

This is great! But requires some manual resolution of conflicts. So will merge it after handling a few simpler PR merges.

Let me know if (and when) you need help to resolve conflicts.

Thanks @PendaGTP if you could look at that it would be awesome. It is mostly the code you have contibuted in the previous PRs and this, so it would be easier for you.

@decyjphr fyi rebase done

I do want to comment that this fix by @PendaGTP works much better than the recent #808 merge when it comes to mistaken globbing issues.

Basically as it stands with current main-enterprise branch with #808, if there is a config like this:

suborgrepos:
  - luv

Then it will be greedy and pull in any repos that match "luv" in any part of the repo name, whereas in this PR, the behavior is that this config would only match the repo called "luv" and that's all.

Testing

• Tested globbing works, for example:

suborgrepos:
  - luv*

This will match any repo that starts with "luv", for example: "luv-mike-repo" will match.

• This did not seem to work:

suborgrepos:
  - *luv*

Our team is good with this behavior, just pointing out that we also tested this scenario.

Background

• About 7-8 months ago, we had a subort config with "admin" in the name that caused safe settings to deploy on several dozen repos that matched "admin" in any part of the repo name.
• Due to this, we diverged from the standard glob.js, but it looks like this PR will allow us to join back up with upstream safe settings once this PR is merged.